sdl3_mixer 3.2.0 (new formula)#276253
Conversation
|
Please keep a PR with force push, |
84b6ffd to
bba24a9
Compare
|
Can this be merged? |
bba24a9 to
816c3ea
Compare
816c3ea to
b499362
Compare
|
I'm fairly new to homebrew formula dev (previously just custom tap setup), so apologize if I'm off base here. I was looking at testing out this PR locally and was able to get it to work by referencing the already existing sdl3_image formula and adding the following flags to the args array (I confirmed they exist via the sdl_mixer repo cmake file): Running the following commands: Resulted in: And when I tested this build with my project (previously tested with the latest SDL_mixer via git and cmake), everything worked as expected. Regarding the comment above about the |
|
Works for me as well: I think it can be merged now |
|
@atticus5 Can you squash your commit to the first one? |
7d05aba to
f35188f
Compare
|
@daeho-ro done! |
|
When is this going to master branch? |
f35188f to
b14cedd
Compare
|
CI looks messed, rebase to origin/main. |
b14cedd to
aaa1b6e
Compare
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
|
|
Co-authored-by: Carlo Cabrera <github@carlo.cab> fix linkage issues
aaa1b6e to
4cda0fd
Compare
|
🤖 An automated task has requested bottles to be published to this PR. Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Generated the first template from sdl2_mixer, then did some cleanup, ran all the tests, including a test in my project with the installed library and was fine.